Use a FrameAssociatedLoader when downloading image resources.

content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc

Index: content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
diff --git a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
index 33868c3b1d9f1727073f5b13f025c6eef83fe4ac..8dbeade2702d5d8f24aba093043584512d1deb99 100644
--- a/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
+++ b/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
@@ -10,10 +10,12 @@
 #include "content/public/renderer/resource_fetcher.h"
 #include "third_party/WebKit/public/platform/WebURLResponse.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
+#include "third_party/WebKit/public/web/WebURLLoaderOptions.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/geometry/size.h"
 
 using blink::WebFrame;
+using blink::WebURLLoaderOptions;
 using blink::WebURLRequest;
 using blink::WebURLResponse;
 
@@ -30,11 +32,18 @@ MultiResolutionImageResourceFetcher::MultiResolutionImageResourceFetcher(
       http_status_code_(0),
       image_url_(image_url) {
   fetcher_.reset(ResourceFetcher::Create(image_url));
+
+  WebURLLoaderOptions options;
+  options.allowCredentials = true;

[Nate Chapin, 2015/01/06 18:18:42]

I don't feel qualified to approve a change to favicon credential behavior. Would
you mind doing this as part of a separate patch, with a broader set of
reviewers?

[mlamouri (slow - plz ping), 2015/01/07 10:08:06]

This is actually not changing any behaviour. The previous loader
(PLATFORM_LOADER) would send credentials and allow cross origin requests. This
is why I'm passing those options to the FrameAssociatedLoader. If you look at
bug 114082 you will see attempts to make favicon requests not using credentials.

I understand that my CL description is a bit confusing and might suggest that I
change the behaviour. I will update that.

+  options.crossOriginRequestPolicy =
+      WebURLLoaderOptions::CrossOriginRequestPolicyAllow;
+  fetcher_->SetLoaderOptions(options);
+
   fetcher_->Start(
       frame,
       request_context,
       WebURLRequest::FrameTypeNone,
-      ResourceFetcher::PLATFORM_LOADER,
+      ResourceFetcher::FRAME_ASSOCIATED_LOADER,

[mlamouri (slow - plz ping), 2015/01/06 17:32:50]

If exposing all image loading in the devtools can be a problem, we could use the
FRAME_ASSOCIATED_LOADER when the request type is FAVICON.

       base::Bind(&MultiResolutionImageResourceFetcher::OnURLFetchComplete,
                  base::Unretained(this)));
 }