Use a FrameAssociatedLoader when downloading image resources.

content/renderer/fetchers/resource_fetcher_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/fetchers/resource_fetcher_impl.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "third_party/WebKit/public/platform/Platform.h"
 #include "third_party/WebKit/public/platform/WebHTTPBody.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebURLError.h"

[tyoshino (SeeGerritForStatus), 2015/01/14 04:09:41]

[optional] remove this unused include using this opportunity and include
WebString.h instead

[mlamouri (slow - plz ping), 2015/01/14 14:31:17]

Done.

 #include "third_party/WebKit/public/platform/WebURLLoader.h"
 #include "third_party/WebKit/public/platform/WebURLRequest.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebKit.h"
 #include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 
 using base::TimeDelta;
 using blink::WebFrame;
 using blink::WebHTTPBody;
 using blink::WebSecurityPolicy;
 using blink::WebURLError;

[tyoshino (SeeGerritForStatus), 2015/01/14 04:09:41]

[optional] remove this unused using using this opportunity

[mlamouri (slow - plz ping), 2015/01/14 14:31:17]

Done.

 using blink::WebURLLoader;
+using blink::WebURLLoaderOptions;

[tyoshino (SeeGerritForStatus), 2015/01/14 04:09:41]

just one occurrence. maybe it's just fine to add blink:: to L88?

[mlamouri (slow - plz ping), 2015/01/14 14:31:17]

I removed all the |using| while I was at it. Most of them where used once. One
was not used. One used twice.

 using blink::WebURLRequest;
 using blink::WebURLResponse;
 
 namespace content {
 
 // static
 ResourceFetcher* ResourceFetcher::Create(const GURL& url) {
   return new ResourceFetcherImpl(url);
 }
 
@@ skipping 33 matching lines @@
         blink::WebReferrerPolicyDefault,
         request_.url(),
         blink::WebString::fromUTF8(value));
     request_.setHTTPReferrer(referrer, blink::WebReferrerPolicyDefault);
   } else {
     request_.setHTTPHeaderField(blink::WebString::fromUTF8(header),
                                 blink::WebString::fromUTF8(value));
   }
 }
 
+void ResourceFetcherImpl::SetSkipServiceWorker(bool skip_service_worker) {
+  DCHECK(!request_.isNull());
+  DCHECK(!loader_);
+
+  request_.setSkipServiceWorker(skip_service_worker);
+}
+
+void ResourceFetcherImpl::SetLoaderOptions(const WebURLLoaderOptions& options) {
+  DCHECK(!request_.isNull());
+  DCHECK(!loader_);
+
+  options_ = options;
+}
+
 void ResourceFetcherImpl::Start(WebFrame* frame,
                                 WebURLRequest::RequestContext request_context,
                                 WebURLRequest::FrameType frame_type,
                                 LoaderType loader_type,
                                 const Callback& callback) {
   DCHECK(!loader_);
   DCHECK(!request_.isNull());
   DCHECK(callback_.is_null());
   DCHECK(!completed());
   if (!request_.httpBody().isNull())
     DCHECK_NE("GET", request_.httpMethod().utf8()) << "GETs can't have bodies.";
 
   callback_ = callback;
 
   request_.setRequestContext(request_context);
   request_.setFrameType(frame_type);
   request_.setFirstPartyForCookies(frame->document().firstPartyForCookies());
   frame->dispatchWillSendRequest(request_);
 
   switch (loader_type) {
     case PLATFORM_LOADER:
       loader_.reset(blink::Platform::current()->createURLLoader());
       break;
     case FRAME_ASSOCIATED_LOADER:
-      loader_.reset(frame->createAssociatedURLLoader());
+      loader_.reset(frame->createAssociatedURLLoader(options_));
       break;
   }
   loader_->loadAsynchronously(request_, this);
 
   // No need to hold on to the request.
   request_.reset();
 }
 
 void ResourceFetcherImpl::SetTimeout(const base::TimeDelta& timeout) {
   DCHECK(loader_);
@@ skipping 13 matching lines @@
   callback.Run(status() == LOAD_FAILED ? blink::WebURLResponse() : response(),
                status() == LOAD_FAILED ? std::string() : data());
 }
 
 void ResourceFetcherImpl::Cancel() {
   loader_->cancel();
   WebURLLoaderClientImpl::Cancel();
 }
 
 }  // namespace content