Remove gray background for non-focused selected list items on autofillEditAddress page.

chrome/browser/resources/options/autofill_edit_overlay.css

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
 #autofill-edit-address-overlay {
   min-width: 55em;
 }
 
 #autofill-edit-credit-card-overlay {
   min-width: 500px;
@@ skipping 30 matching lines @@
   border: 1px solid darkGray;
   border-radius: 2px;
   /* Border should go "inside" the height. */
   box-sizing: border-box;
   /* Set the line-height and min-height to match the height of an input element,
    * so that even empty cells renderer with the correct height. */
   height: 2em;
   line-height: 2em;
 }
 
+#autofill-edit-address-overlay list:not([has-element-focus]) >
+    [selected]:not(:hover) {
+  background-color: white;

[Dan Beam, 2015/01/22 22:38:55]

don't use white, use `none` or `transparent`

[Dan Beam, 2015/01/22 22:38:55]

i'm confused, are we overriding this rule?
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

i'd expect to see a more specific selector to override:

  #autofill-edit-address-overlay list > [lead][selected],
  #autofill-edit-address-overlay list:focus > [lead][selected] {
    background-color: /* lighter */;
  }

but maybe for all dialogs (instead of just this one).

[bondd, 2015/01/23 03:45:54]

Done.

[bondd, 2015/01/23 03:45:54]

We are overriding this rule:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

not(:hover) added so that item will still have gray background when hovering.

Originally you and I were planning to only lighten the gray, but jhawkins@
convinced me that this specific dialog (not all list dialogs) would be less
confusing for sighted users if the highlight were removed completely. See
discussion on bug https://crbug.com/444770
That is why it's only done for this one dialog instead of all of them. If we
were to lighten the gray instead, then I think we should do it for all dialogs.

+}
+
+#autofill-edit-address-overlay list:not([has-element-focus]) > *:not(:hover)
+    .row-delete-button {
+  opacity: 0;
+  pointer-events: none;
+}

[bondd, 2015/01/14 03:18:48]

Row delete button was also visible when gray background was showing. Hide it
using the same settings as here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

[James Hawkins, 2015/01/14 17:34:34]

Please add a TODO to clean up the hack.

[Dan Beam, 2015/01/22 22:38:55]

how is this a hack?

[bondd, 2015/01/23 03:45:54]

It's a hack if you agree that the old list behavior is the "right" way, and
having the new list behavior in this dialog is a bug that should be fixed
eventually. See jhawkins@ comments on https://crbug.com/444770

If you consider the new way to be just as right as the old way (due to
considerations for webui consistency, better for AT users, etc.) then it's not a
hack.

+
 :-webkit-any(#autofill-edit-credit-card-overlay, #autofill-edit-address-overlay)
     .settings-row label > :-webkit-any(input, select, textarea, list) {
   margin-top: 4px;
 }
 
 .input-group > * {
   -webkit-box-orient: vertical;
   -webkit-margin-end: 2px;
   display: -webkit-inline-box;
   vertical-align: top;
 }
 
 #autofill-edit-credit-card-overlay .content-area > *:first-child {
   margin-top: 0;
 }