Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5239)

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 840493002: Introduce new test for bookmark loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks-minimal
Patch Set: Add getter for bookmarks Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf_extension_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index b82f9132842777c3bd55ae2556471b51762a743d..d387319f2fd3d0b99b7925f2355d7c837ca08fc7 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -613,5 +613,16 @@ PDFViewer.prototype = {
*/
get viewport() {
return this.viewport_;
+ },
+
+ /**
+ * Each bookmark is an Object containing a:
+ * - title
+ * - page
Sam McNally 2015/01/18 23:56:57 Optional?
Alexandre Carlton 2015/01/19 00:42:47 Done.
+ * - array of children (themselves bookmarks)
+ * @type {Array} the top-level bookmarks of the PDF.
+ */
+ get bookmarks() {
+ return this.bookmarks_;
}
};
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf_extension_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698