Chromium Code Reviews| Index: chrome/browser/resources/pdf/pdf_extension_test.cc |
| diff --git a/chrome/browser/resources/pdf/pdf_extension_test.cc b/chrome/browser/resources/pdf/pdf_extension_test.cc |
| index 64b73fada0d2172f70cea11e3956d5416a41ff54..77bd8cf2609823dffecb2cf80186bdb028651146 100644 |
| --- a/chrome/browser/resources/pdf/pdf_extension_test.cc |
| +++ b/chrome/browser/resources/pdf/pdf_extension_test.cc |
| @@ -40,7 +40,8 @@ class PDFExtensionTest : public ExtensionApiTest { |
| ExtensionApiTest::TearDownOnMainThread(); |
| } |
| - void RunTestsInFile(std::string filename) { |
| + void RunTestsInFile(std::string filename, |
| + std::string pdf_filename) { |
|
raymes
2015/01/23 00:34:51
Will this all fit on a single line?
Alexandre Carlton
2015/01/23 01:46:20
Yes, I'll change it.
|
| base::FilePath pdf_path; |
| ASSERT_TRUE(PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path)); |
| ASSERT_TRUE( |
| @@ -60,7 +61,7 @@ class PDFExtensionTest : public ExtensionApiTest { |
| extensions::ResultCatcher catcher; |
| - GURL url(embedded_test_server()->GetURL("/pdf/test.pdf")); |
| + GURL url(embedded_test_server()->GetURL("/pdf/" + pdf_filename)); |
| GURL extension_url( |
| "chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?" + |
| url.spec()); |
| @@ -85,13 +86,17 @@ class PDFExtensionTest : public ExtensionApiTest { |
| }; |
| IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Basic) { |
| - RunTestsInFile("basic_test.js"); |
| + RunTestsInFile("basic_test.js", "test.pdf"); |
| } |
| IN_PROC_BROWSER_TEST_F(PDFExtensionTest, BasicPlugin) { |
| - RunTestsInFile("basic_plugin_test.js"); |
| + RunTestsInFile("basic_plugin_test.js", "test.pdf"); |
| } |
| IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Viewport) { |
| - RunTestsInFile("viewport_test.js"); |
| + RunTestsInFile("viewport_test.js", "test.pdf"); |
| +} |
| + |
| +IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Bookmark) { |
| + RunTestsInFile("bookmarks_test.js", "test-bookmarks.pdf"); |
| } |