Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 840493002: Introduce new test for bookmark loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks-minimal
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/pdf/pdf.js
diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js
index 047d47a0a9d18c835245b08410d6bea8347002a2..20963ad906229bfb923b048da66492480dc0de44 100644
--- a/chrome/browser/resources/pdf/pdf.js
+++ b/chrome/browser/resources/pdf/pdf.js
@@ -45,6 +45,7 @@ PDFViewer.MIN_TOOLBAR_OFFSET = 15;
function PDFViewer(streamDetails) {
this.streamDetails = streamDetails;
this.loaded = false;
+ this.bookmarksLoaded = false;
// The sizer element is placed behind the plugin element to cause scrollbars
// to be displayed in the window. It is sized according to the document size
@@ -421,7 +422,12 @@ PDFViewer.prototype = {
break;
case 'bookmarks':
this.bookmarks = message.data.bookmarks;
- console.log(this.bookmarks);
+ this.bookmarksLoaded = true;
+ var loadEvent = new Event('bookmarksload');
+ window.dispatchEvent(loadEvent);
+ this.sendScriptingMessage_({
+ type: 'bookmarksLoaded'
+ });
raymes 2015/01/06 05:52:29 if we ensure that bookmark information is sent her
raymes 2015/01/13 07:25:12 (we also wouldn't need the bookmarksLoaded member
Alexandre Carlton 2015/01/15 05:01:41 Done.
break;
}
},
« no previous file with comments | « no previous file | chrome/browser/resources/pdf/pdf_extension_test.cc » ('j') | chrome/browser/resources/pdf/pdf_extension_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698