sky/engine/core/rendering/RenderParagraph.cpp - Issue 840483004: Get rid of the *AndFullPaintInvalidation methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderParagraph.cpp

Issue 840483004: Get rid of the *AndFullPaintInvalidation methods. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderParagraph.cpp

diff --git a/sky/engine/core/rendering/RenderParagraph.cpp b/sky/engine/core/rendering/RenderParagraph.cpp

index 83de4275bd708c8e7241ccffb8b8eb4d8194a3b8..f17d9abc8b970ad069f3015d13bf2aec0884bba2 100644

--- a/sky/engine/core/rendering/RenderParagraph.cpp

+++ b/sky/engine/core/rendering/RenderParagraph.cpp

@@ -1384,7 +1384,7 @@ RootInlineBox* RenderParagraph::determineStartPosition(LineLayoutState& layoutSt

if (layoutState.isFullLayout()) {

// If we encountered a new float and have inline children, mark ourself to force us to issue paint invalidations.

if (layoutState.hasInlineChild() && !selfNeedsLayout()) {

- setNeedsLayoutAndFullPaintInvalidation(MarkOnlyThis);

+ setNeedsLayout(MarkOnlyThis);

}

// FIXME: This should just call deleteLineBoxTree, but that causes