media/mojo/interfaces/content_decryption_module_factory.mojom - Issue 840473002: media: Support creation and SetCdm() for mojo based CDM.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/mojo/interfaces/content_decryption_module_factory.mojom

Issue 840473002: media: Support creation and SetCdm() for mojo based CDM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix TODO. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo;

	6

	7 import "media/mojo/interfaces/content_decryption_module.mojom";

	8

	9 // An interface to request a ContentDecryptionModule service for \|key_system\|

	10 // and \|security_origin\|. The \|cdm\| can be null if the requested service is not

	11 // supported (e.g. unsupported key system).
	ddorwin 2015/05/15 19:10:07 Is that the only mechanism we have to report error Is that the only mechanism we have to report errors? Does this need to change now that creation was made asynchronous in Blink & Chromium? Should we use a similar promise model? Update: I saw the TODOs in the .cc file. Perhaps they should be here since this is the interface.
	12 // \|cdm_id\| is a client generated ID that will be used by other services to get

	13 // access to the CDM. See SetCdm() method in the MediaRenderer interface for

	14 // details.

	15 interface ContentDecryptionModuleFactory {

	16 Create(string key_system,

	17 string security_origin,
	ddorwin 2015/05/15 19:10:07 FYI, I believe we are now passing more config info FYI, I believe we are now passing more config information.
	18 int32 cdm_id,

	19 ContentDecryptionModule&? cdm);

	20 };

OLD	NEW

« media/base/cdm_context.h ('K') | « media/mojo/interfaces/content_decryption_module.mojom ('k') | media/mojo/interfaces/media_renderer.mojom » ('j') | media/mojo/services/mojo_cdm.h » ('J')