Prepare blink to support testing of icon attribute for <menuitem>.

Prepare blink to support testing of icon attribute for <menuitem>.

BUG=87553
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187995

[pals, 2015-01-06 05:14:29]

sanjoy.pal@samsung.com changed reviewers:
+ chrishtr@chromium.org

[pals, 2015-01-06 05:14:54]

On 2015/01/06 05:14:29, pals wrote:
> mailto:sanjoy.pal@samsung.com changed reviewers:
> + mailto:chrishtr@chromium.org

This is need to land https://codereview.chromium.org/805153005/. PTAL.

[pals, 2015-01-06 05:15:00]

The CQ bit was checked by sanjoy.pal@samsung.com

[pals, 2015-01-06 05:15:02]

The CQ bit was unchecked by sanjoy.pal@samsung.com

[chrishtr, 2015-01-06 18:13:45]

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h
File public/web/WebMenuItemInfo.h (right):

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h...
public/web/WebMenuItemInfo.h:41: struct WebMenuItemInfo {
Is this whole struct just for testing?

[pals, 2015-01-07 05:31:33]

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h
File public/web/WebMenuItemInfo.h (right):

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h...
public/web/WebMenuItemInfo.h:41: struct WebMenuItemInfo {
On 2015/01/06 18:13:45, chrishtr wrote:
> Is this whole struct just for testing?

No, this is not only for testing. This is used as common interface to pass on
custom items data from blink to chromium side.

I have this CL https://codereview.chromium.org/802233004/ which depends on
https://codereview.chromium.org/805153005/ for testing.

[chrishtr, 2015-01-07 17:56:54]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-01-07 17:56:55]

lgtm

[commit-bot: I haz the power, 2015-01-07 17:57:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840453003/1

[commit-bot: I haz the power, 2015-01-07 21:13:04]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187995

[tkent, 2015-02-02 00:35:40]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-02-02 00:35:41]

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h
File public/web/WebMenuItemInfo.h (right):

https://codereview.chromium.org/840453003/diff/1/public/web/WebMenuItemInfo.h...
public/web/WebMenuItemInfo.h:61: WebString icon;
This should have a comment explaining the content of the string value.  e.g.  Is
this URL?  Can it be a relative URL?