Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 84043002: Add support for 64-bit Windows compiles in GN (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for 64-bit Windows compiles in GN BUG=297677, 322109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -93 lines) Patch
build/config/BUILDCONFIG.gn View 3 chunks +21 lines, -5 lines 0 comments Download
build/config/win/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
build/toolchain/win/BUILD.gn View 4 chunks +75 lines, -82 lines 0 comments Download
build/toolchain/win/setup_toolchain.py View 2 chunks +53 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
I have having upload problems so you'll have to review by looking at the diff, ...
7 years, 1 month ago (2013-11-22 20:22:34 UTC) #1
scottmg
sorry, I didn't notice this before in gn/args.cc, but "ia64" is wrong, it should be ...
7 years, 1 month ago (2013-11-22 20:29:34 UTC) #2
brettw
7 years, 1 month ago (2013-11-22 21:52:13 UTC) #3
On 2013/11/22 20:29:34, scottmg wrote:
> sorry, I didn't notice this before in gn/args.cc, but "ia64" is wrong, it
should
> be either "x64" or "amd64". "ia64" is the (mostly dead) Itanium, not x86++.

Due to me messing everything up, this is moved to
https://codereview.chromium.org/83733005/

Powered by Google App Engine
This is Rietveld 408576698