Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: sky/engine/core/rendering/RenderSelectionInfo.h

Issue 840403003: First pass at deleting paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderObjectChildList.cpp ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderSelectionInfo.h
diff --git a/sky/engine/core/rendering/RenderSelectionInfo.h b/sky/engine/core/rendering/RenderSelectionInfo.h
index 76674a222c4abd5ba7c01e250b94c76acbf81d99..03e54f8e00eb1c246f7184814ca53ffc7356cb2c 100644
--- a/sky/engine/core/rendering/RenderSelectionInfo.h
+++ b/sky/engine/core/rendering/RenderSelectionInfo.h
@@ -57,6 +57,7 @@ protected:
RenderObject::SelectionState m_state;
};
+// FIXME(sky): Remove this class.
// This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject.
class RenderSelectionInfo final : public RenderSelectionInfoBase {
public:
@@ -72,7 +73,6 @@ public:
void invalidatePaint()
{
- m_object->invalidatePaintUsingContainer(m_paintInvalidationContainer, enclosingIntRect(m_rect), InvalidationSelection);
}
LayoutRect rect() const { return m_rect; }
@@ -81,6 +81,7 @@ private:
LayoutRect m_rect; // relative to paint invalidation container
};
+// FIXME(sky): Remove this class.
// This struct is used when the selection changes to cache the old and new state of the selection for each RenderBlock.
class RenderBlockSelectionInfo final : public RenderSelectionInfoBase {
public:
@@ -95,7 +96,6 @@ public:
void invalidatePaint()
{
- m_object->invalidatePaintUsingContainer(m_paintInvalidationContainer, enclosingIntRect(m_rects), InvalidationSelection);
}
RenderBlock* block() const { return toRenderBlock(m_object); }
« no previous file with comments | « sky/engine/core/rendering/RenderObjectChildList.cpp ('k') | sky/engine/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698