Add support for ios_uirobot

Add support for ios_uirobot

BUG=428729
Committed: https://crrev.com/a46fc56cbdf4fa62d3111f91cc81dc598b24b630
Cr-Commit-Position: refs/heads/master@{#312854}

[rnephew (Wrong account), 2015-01-09 20:57:13]

rnephew@google.com changed reviewers:
+ baxley@chromium.org, carusom@chromium.org, jbudorick@chromium.org,
rnephew@google.com

[rnephew (Wrong account), 2015-01-09 20:57:14]

https://codereview.chromium.org/840393003/diff/1/build/mobile/bling/pylib/uir...
File build/mobile/bling/pylib/uirobot/uirobot_test_instance.py (right):

https://codereview.chromium.org/840393003/diff/1/build/mobile/bling/pylib/uir...
build/mobile/bling/pylib/uirobot/uirobot_test_instance.py:28: raise
NotImplementedError
Need to know the correct default location for Bling.ipa to get rid of this.

[jbudorick, 2015-01-09 22:06:51]

I'm not sure about the directory structure.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
File build/android/pylib/base/test_instance_factory.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_instance_factory.py:11: from pylib.uirobot import
uirobot_test_instance as android_uirobot_test_instance
We generally try to avoid aliasing, but until we move into build/mobile, this is
ok.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_instance_factory.py:15: from bling.pylib.uirobot
import (
ios

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
File build/android/pylib/base/test_run_factory.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:20: from bling.pylib.uirobot import
(
ios

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:22: from bling.pylib.remote.device
import (
ios

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:35:
android_uirobot_test_instance.UirobotTestInstance):
I haven't gotten to the two implementations yet, but it'd be nice if we could
use the same uirobot_test_instance for both OSes.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/uiro...
File build/android/pylib/uirobot/uirobot_test_instance.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/uiro...
build/android/pylib/uirobot/uirobot_test_instance.py:26: self._app_under_test =
os.path.join(
I don't think we should provide a default for this. If it's not passed in the
arguments, this should call error_func. (Obviously, we'd have to pass error_func
into this ctor, too.)

https://codereview.chromium.org/840393003/diff/20001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/test_runne...
build/android/test_runner.py:104: group.add_argument('--device-type',
default='Android',
use the choices kwarg. we can probably put a VALID_DEVICE_TYPES (% name) in
constants.py.

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/__init_...
File build/mobile/ios/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/__init_...
build/mobile/ios/__init__.py:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
no (c)

also, do

git cl upload --no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/_...
File build/mobile/ios/pylib/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/_...
build/mobile/ios/pylib/__init__.py:1: # Copyright (c) 2015 The Chromium Authors.
All rights reserved.
no (c), --no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/c...
File build/mobile/ios/pylib/constants.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/c...
build/mobile/ios/pylib/constants.py:1: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
Why is this in here?

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
File build/mobile/ios/pylib/remote/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
build/mobile/ios/pylib/remote/__init__.py:1: # Copyright (c) 2015 The Chromium
Authors. All rights reserved.
no (c), --no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
File build/mobile/ios/pylib/remote/device/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
build/mobile/ios/pylib/remote/device/__init__.py:1: # Copyright (c) 2015 The
Chromium Authors. All rights reserved.
no (c), --no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
File build/mobile/ios/pylib/remote/device/remote_device_uirobot_run.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
build/mobile/ios/pylib/remote/device/remote_device_uirobot_run.py:23: class
RemoteDeviceUirobotRun(remote_device_test_run.RemoteDeviceTestRun):
We have to be able to use the same object for both OSes. These differ only in a
constant...

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
File build/mobile/ios/pylib/uirobot/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
build/mobile/ios/pylib/uirobot/__init__.py:1: # Copyright (c) 2015 The Chromium
Authors. All rights reserved.
no (c), --no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
File build/mobile/ios/pylib/uirobot/uirobot_test_instance.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
build/mobile/ios/pylib/uirobot/uirobot_test_instance.py:1: # Copyright 2014 The
Chromium Authors. All rights reserved.
2015

--no-find-copies

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
build/mobile/ios/pylib/uirobot/uirobot_test_instance.py:15: class
UirobotTestInstance(test_instance.TestInstance):
This also shouldn't need to be duplicated between the two OSes.

[rnephew (Wrong account), 2015-01-09 23:35:37]

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
File build/android/pylib/base/test_instance_factory.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_instance_factory.py:11: from pylib.uirobot import
uirobot_test_instance as android_uirobot_test_instance
On 2015/01/09 22:06:50, jbudorick wrote:
> We generally try to avoid aliasing, but until we move into build/mobile, this
is
> ok.

Acknowledged.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_instance_factory.py:15: from bling.pylib.uirobot
import (
On 2015/01/09 22:06:50, jbudorick wrote:
> ios

Done.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
File build/android/pylib/base/test_run_factory.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:20: from bling.pylib.uirobot import
(
On 2015/01/09 22:06:50, jbudorick wrote:
> ios

Done.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:22: from bling.pylib.remote.device
import (
On 2015/01/09 22:06:50, jbudorick wrote:
> ios

Done.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/base...
build/android/pylib/base/test_run_factory.py:35:
android_uirobot_test_instance.UirobotTestInstance):
On 2015/01/09 22:06:50, jbudorick wrote:
> I haven't gotten to the two implementations yet, but it'd be nice if we could
> use the same uirobot_test_instance for both OSes.

Done.

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/uiro...
File build/android/pylib/uirobot/uirobot_test_instance.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/pylib/uiro...
build/android/pylib/uirobot/uirobot_test_instance.py:26: self._app_under_test =
os.path.join(
On 2015/01/09 22:06:50, jbudorick wrote:
> I don't think we should provide a default for this. If it's not passed in the
> arguments, this should call error_func. (Obviously, we'd have to pass
error_func
> into this ctor, too.)

Done.

https://codereview.chromium.org/840393003/diff/20001/build/android/test_runne...
File build/android/test_runner.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/android/test_runne...
build/android/test_runner.py:104: group.add_argument('--device-type',
default='Android',
On 2015/01/09 22:06:50, jbudorick wrote:
> use the choices kwarg. we can probably put a VALID_DEVICE_TYPES (% name) in
> constants.py.

Done.

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/__init_...
File build/mobile/ios/__init__.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/__init_...
build/mobile/ios/__init__.py:1: # Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/01/09 22:06:50, jbudorick wrote:
> no (c)
> 
> also, do
> 
> git cl upload --no-find-copies

Deleted

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
File build/mobile/ios/pylib/remote/device/remote_device_uirobot_run.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/r...
build/mobile/ios/pylib/remote/device/remote_device_uirobot_run.py:23: class
RemoteDeviceUirobotRun(remote_device_test_run.RemoteDeviceTestRun):
On 2015/01/09 22:06:50, jbudorick wrote:
> We have to be able to use the same object for both OSes. These differ only in
a
> constant...

Done.

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
File build/mobile/ios/pylib/uirobot/uirobot_test_instance.py (right):

https://codereview.chromium.org/840393003/diff/20001/build/mobile/ios/pylib/u...
build/mobile/ios/pylib/uirobot/uirobot_test_instance.py:15: class
UirobotTestInstance(test_instance.TestInstance):
On 2015/01/09 22:06:50, jbudorick wrote:
> This also shouldn't need to be duplicated between the two OSes.

Done.

[rnephew (Wrong account), 2015-01-22 20:01:18]

Rebase is done, ready for review.

[jbudorick, 2015-01-22 20:34:50]

https://codereview.chromium.org/840393003/diff/140001/build/android/pylib/rem...
File build/android/pylib/remote/device/remote_device_uirobot_test_run.py
(right):

https://codereview.chromium.org/840393003/diff/140001/build/android/pylib/rem...
build/android/pylib/remote/device/remote_device_uirobot_test_run.py:44: 
might want to throw an exception here in an else block, just as a sanity check.

https://codereview.chromium.org/840393003/diff/140001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/840393003/diff/140001/build/android/test_runn...
build/android/test_runner.py:104: group.add_argument('--device-type',
default='Android',
Let's start this in the remote device options for now.

[rnephew (Wrong account), 2015-01-22 21:59:42]

https://codereview.chromium.org/840393003/diff/140001/build/android/pylib/rem...
File build/android/pylib/remote/device/remote_device_uirobot_test_run.py
(right):

https://codereview.chromium.org/840393003/diff/140001/build/android/pylib/rem...
build/android/pylib/remote/device/remote_device_uirobot_test_run.py:44: 
On 2015/01/22 20:34:50, jbudorick wrote:
> might want to throw an exception here in an else block, just as a sanity
check.

Done.

https://codereview.chromium.org/840393003/diff/140001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/840393003/diff/140001/build/android/test_runn...
build/android/test_runner.py:104: group.add_argument('--device-type',
default='Android',
On 2015/01/22 20:34:50, jbudorick wrote:
> Let's start this in the remote device options for now.

Done.

[jbudorick, 2015-01-22 22:01:06]

lgtm w/ nit

https://codereview.chromium.org/840393003/diff/160001/build/android/pylib/rem...
File build/android/pylib/remote/device/remote_device_uirobot_test_run.py
(right):

https://codereview.chromium.org/840393003/diff/160001/build/android/pylib/rem...
build/android/pylib/remote/device/remote_device_uirobot_test_run.py:46: 'Unkown
device type: %s' % self._env.device_type)
nit: only a 4 space indent here

[rnephew (Wrong account), 2015-01-22 22:02:56]

https://codereview.chromium.org/840393003/diff/160001/build/android/pylib/rem...
File build/android/pylib/remote/device/remote_device_uirobot_test_run.py
(right):

https://codereview.chromium.org/840393003/diff/160001/build/android/pylib/rem...
build/android/pylib/remote/device/remote_device_uirobot_test_run.py:46: 'Unkown
device type: %s' % self._env.device_type)
On 2015/01/22 22:01:05, jbudorick wrote:
> nit: only a 4 space indent here

Done.

[rnephew (Wrong account), 2015-01-22 22:03:02]

The CQ bit was checked by rnephew@google.com

[commit-bot: I haz the power, 2015-01-22 22:03:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840393003/180001

[commit-bot: I haz the power, 2015-01-22 22:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 22:24:47]

Try jobs failed on following builders:
  win8_chromium_gn_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)

Try jobs failed on following builders:
  win8_chromium_gn_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)

[rnephew (Wrong account), 2015-01-22 22:26:56]

The CQ bit was checked by rnephew@google.com

[commit-bot: I haz the power, 2015-01-22 22:28:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840393003/180001

[commit-bot: I haz the power, 2015-01-22 22:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 22:30:20]

Try jobs failed on following builders:
  win8_chromium_gn_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)

[rnephew (Wrong account), 2015-01-22 23:39:51]

The CQ bit was checked by rnephew@google.com

[commit-bot: I haz the power, 2015-01-22 23:42:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840393003/180001

[commit-bot: I haz the power, 2015-01-23 01:46:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 01:46:19]

Exceeded time limit waiting for builds to trigger.

[rnephew (Wrong account), 2015-01-23 15:58:36]

The CQ bit was checked by rnephew@google.com

[commit-bot: I haz the power, 2015-01-23 15:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/840393003/180001

[commit-bot: I haz the power, 2015-01-23 16:00:44]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-01-23 16:01:44]

Patchset 10 (id:??) landed as
https://crrev.com/a46fc56cbdf4fa62d3111f91cc81dc598b24b630
Cr-Commit-Position: refs/heads/master@{#312854}