Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840373004: Disable OutOfProcessPPAPITest under ThreadSanitizer. (Closed)

Created:
5 years, 11 months ago by Alexander Potapenko
Modified:
5 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable OutOfProcessPPAPITest under ThreadSanitizer. BUG=448323 TBR=raymes@chromium.org Committed: https://crrev.com/aacff2b19ce4805964ab5f1d9ea3c4c47853bc4f Cr-Commit-Position: refs/heads/master@{#311458}

Patch Set 1 #

Patch Set 2 : Also disable Instance_ExecuteScriptAtInstanceShutdown #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +10 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Alexander Potapenko
Raymes, can you please take a look?
5 years, 11 months ago (2015-01-14 09:39:13 UTC) #1
Alexander Potapenko
TBR
5 years, 11 months ago (2015-01-14 11:09:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840373004/20001
5 years, 11 months ago (2015-01-14 11:11:05 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 12:03:49 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aacff2b19ce4805964ab5f1d9ea3c4c47853bc4f Cr-Commit-Position: refs/heads/master@{#311458}
5 years, 11 months ago (2015-01-14 12:04:36 UTC) #6
raymes
5 years, 11 months ago (2015-01-14 23:40:24 UTC) #7
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/840373004/diff/20001/content/test/ppapi/ppapi...
File content/test/ppapi/ppapi_browsertest.cc (right):

https://codereview.chromium.org/840373004/diff/20001/content/test/ppapi/ppapi...
content/test/ppapi/ppapi_browsertest.cc:91:
DISABLE_IF_TSAN(Instance_ExecuteScriptAtInstanceShutdown)) {
nit: can you link the bug here too?

Powered by Google App Engine
This is Rietveld 408576698