Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 840373003: MacViews: Fix app_list_unittests for mouseover change in r311143 (Closed)

Created:
5 years, 11 months ago by tapted
Modified:
5 years, 11 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20141229-MacViews-bringup2-plus-glevin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix app_list_unittests for mouseover change in r311143 Compile of app_list_unittests on toolkit-views enabled Mac regressed in r311143 because it accessed aura::Window and there is no Aura on Mac yet. The MouseHoverToHighlight passes on Mac - it just needs to initialize the event generator differently. TapGestureToHighlight is disabled on Mac, since there are no touch events on desktop Mac. BUG=441573, 445520, 365977 Committed: https://crrev.com/5657bc22e55a5d9bc4e5cb63e9b4b0ffc55ed377 Cr-Commit-Position: refs/heads/master@{#311375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ui/app_list/views/app_list_main_view_unittest.cc View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi jack, please take a look
5 years, 11 months ago (2015-01-13 06:22:43 UTC) #2
jackhou1
lgtm
5 years, 11 months ago (2015-01-14 00:34:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840373003/1
5 years, 11 months ago (2015-01-14 00:42:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 00:47:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:49:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5657bc22e55a5d9bc4e5cb63e9b4b0ffc55ed377
Cr-Commit-Position: refs/heads/master@{#311375}

Powered by Google App Engine
This is Rietveld 408576698