Issue 840343005: Add pdfium_unittests to BUILD.gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 840343005: Add pdfium_unittests to BUILD.gn (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
Bo Xu, Lei Zhang, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add pdfium_unittests to BUILD.gn Brings GN build up to sync with GYP build for this test binary. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5621dc444be3d2a5f7c6198b1e14695118a346a5

Patch Set 2 : Alphabetical order #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	BUILD.gn	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/840343005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/840343005/diff/1/BUILD.gn#newcode799 BUILD.gn:799: "core/src/fxcrt/fx_basic_bstring_unittest.cpp", nit: alphabetical order

5 years, 11 months ago (2015-01-09 21:44:41 UTC) #4

Tom Sepez

Committed patchset #2 (id:20001) manually as 5621dc444be3d2a5f7c6198b1e14695118a346a5 (presubmit successful).

5 years, 11 months ago (2015-01-09 21:54:40 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 840343005: Add pdfium_unittests to BUILD.gn (Closed)

Description

Patch Set 1 #

Patch Set 2 : Alphabetical order #

Messages