Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 840343005: Add pdfium_unittests to BUILD.gn (Closed)

Created:
6 years, 1 month ago by Tom Sepez
Modified:
6 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add pdfium_unittests to BUILD.gn Brings GN build up to sync with GYP build for this test binary. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5621dc444be3d2a5f7c6198b1e14695118a346a5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alphabetical order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Please review.
6 years, 1 month ago (2015-01-09 20:32:44 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/840343005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/840343005/diff/1/BUILD.gn#newcode799 BUILD.gn:799: "core/src/fxcrt/fx_basic_bstring_unittest.cpp", nit: alphabetical order
6 years, 1 month ago (2015-01-09 21:44:41 UTC) #4
Tom Sepez
Committed patchset #2 (id:20001) manually as 5621dc444be3d2a5f7c6198b1e14695118a346a5 (presubmit successful).
6 years, 1 month ago (2015-01-09 21:54:40 UTC) #5
brucedawson
6 years, 1 month ago (2015-01-09 21:54:49 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698