Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 84033003: Disable ES3 msaa on ARM (Closed)

Created:
7 years, 1 month ago by no sievers
Modified:
7 years, 1 month ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), Sami
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : handle cros #

Total comments: 1

Patch Set 4 : argh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
no sievers
ptal
7 years, 1 month ago (2013-11-22 20:57:26 UTC) #1
piman
https://codereview.chromium.org/84033003/diff/30001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/84033003/diff/30001/gpu/config/gpu_driver_bug_list_json.cc#newcode717 gpu/config/gpu_driver_bug_list_json.cc:717: "gl_vendor": { Unfortunately, selecting on gl_vendor/gl_renderer doesn't (yet) work ...
7 years, 1 month ago (2013-11-22 21:14:39 UTC) #2
no sievers
On 2013/11/22 21:14:39, piman wrote: > https://codereview.chromium.org/84033003/diff/30001/gpu/config/gpu_driver_bug_list_json.cc > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/84033003/diff/30001/gpu/config/gpu_driver_bug_list_json.cc#newcode717 > ...
7 years, 1 month ago (2013-11-22 21:19:30 UTC) #3
piman
https://codereview.chromium.org/84033003/diff/100001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/84033003/diff/100001/gpu/config/gpu_driver_bug_list_json.cc#newcode741 gpu/config/gpu_driver_bug_list_json.cc:741: "use_virtualized_gl_contexts" disable_framebuffer_multisample - I see what you did there ...
7 years, 1 month ago (2013-11-22 21:26:45 UTC) #4
no sievers
On 2013/11/22 21:26:45, piman wrote: > https://codereview.chromium.org/84033003/diff/100001/gpu/config/gpu_driver_bug_list_json.cc > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/84033003/diff/100001/gpu/config/gpu_driver_bug_list_json.cc#newcode741 > ...
7 years, 1 month ago (2013-11-22 21:28:14 UTC) #5
piman
LGTM, thanks!
7 years, 1 month ago (2013-11-22 21:30:45 UTC) #6
no sievers
7 years, 1 month ago (2013-11-22 21:37:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r236832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698