Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 840323002: Set text-rendering to 'auto' when font shorthand is used in html.css. (Closed)

Created:
5 years, 11 months ago by andersr
Modified:
5 years, 11 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set text-rendering to 'auto' when font shorthand is used in html.css. There is currently a bug causing invisible tabs whenever text-rendering: optimizeLegibility is used. Until recently, we (accidentally) over-wrote the text-rendering property when font shorthands were used, effectively masking the problem for the matching elements. This patch adds text-rendering:auto to html.css, for compatibility. R=timloh@chromium.org BUG=446405 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/css/html.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
andersr
Should we do this? I can see how for example code-editor apps might be affected ...
5 years, 11 months ago (2015-01-09 16:29:05 UTC) #1
Timothy Loh
On 2015/01/09 16:29:05, andersr wrote: > Should we do this? > > I can see ...
5 years, 11 months ago (2015-01-11 23:39:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840323002/1
5 years, 11 months ago (2015-01-12 09:18:05 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 11:37:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188214

Powered by Google App Engine
This is Rietveld 408576698