Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 840253002: Add sticky flag to RegExpMirror. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add sticky flag to RegExpMirror. R=marja@chromium.org Committed: https://crrev.com/affc68b8aad3e4bcf751e3b3271be78c0001cd1c Cr-Commit-Position: refs/heads/master@{#26005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/mirror-debugger.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
This is the fix for your comment in https://codereview.chromium.org/567313003/
5 years, 11 months ago (2015-01-09 07:48:54 UTC) #1
marja
lgtm
5 years, 11 months ago (2015-01-09 09:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840253002/1
5 years, 11 months ago (2015-01-09 09:28:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 09:56:26 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 09:56:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/affc68b8aad3e4bcf751e3b3271be78c0001cd1c
Cr-Commit-Position: refs/heads/master@{#26005}

Powered by Google App Engine
This is Rietveld 408576698