Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 8402005: GTK: Fix profile selection bubble to match the chrome-theme when selected. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Fix profile selection bubble to match the chrome-theme when selected. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107495

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -15 lines) Patch
M chrome/browser/ui/gtk/avatar_menu_bubble_gtk.h View 5 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc View 5 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.h View 1 5 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.cc View 8 chunks +46 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Fixes some small visual defects with the linux avatar selection bubble.
9 years, 1 month ago (2011-10-26 22:43:38 UTC) #1
binji
lgtm with nit. http://codereview.chromium.org/8402005/diff/1/chrome/browser/ui/gtk/avatar_menu_item_gtk.h File chrome/browser/ui/gtk/avatar_menu_item_gtk.h (right): http://codereview.chromium.org/8402005/diff/1/chrome/browser/ui/gtk/avatar_menu_item_gtk.h#newcode95 chrome/browser/ui/gtk/avatar_menu_item_gtk.h:95: // bg[GTK_STATE_SELECTED] or a pointer to ...
9 years, 1 month ago (2011-10-26 22:55:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8402005/4001
9 years, 1 month ago (2011-10-26 23:25:50 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 00:43:38 UTC) #4
Change committed as 107495

Powered by Google App Engine
This is Rietveld 408576698