Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: BUILD.gn

Issue 840173005: Enable more targets in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Enable more targets. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b5ed1137389ae56eed0b5ba138ab461b36759342..29da9dbbde76ae50dd115d211078a7b876326980 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -299,9 +299,7 @@ group("root") {
}
if (is_mac || is_ios) {
- deps -= [
- "//ui/touch_selection",
- ]
+ deps -= [ "//ui/touch_selection" ]
Slava Chigrin 2015/01/20 18:25:20 git cl upload constantly complains on this, so I d
}
if (is_win) {
@@ -316,45 +314,24 @@ group("root") {
"//chrome/test",
"//chrome/utility",
"//components:all_components",
- "//cc",
"//cc/blink",
"//content",
"//content/shell:content_shell",
"//content/test:test_support",
- "//device/bluetooth",
"//extensions/browser",
"//extensions/common",
- "//extensions/common/api",
"//extensions/renderer",
- "//google_apis",
- "//google_apis/gcm",
- "//jingle:notifier",
- "//media",
Slava Chigrin 2015/01/20 18:25:20 Few issues fixed here https://codereview.chromium.
"//media/blink",
- "//media/cast",
- "//media/mojo",
"//mojo",
"//pdf",
"//ppapi:ppapi_c",
"//printing",
"//remoting/client/plugin",
- "//storage/browser",
Slava Chigrin 2015/01/20 18:25:20 Fixed in https://codereview.chromium.org/816293002
- "//sync",
"//third_party/WebKit/public:all_blink",
- "//third_party/angle:translator",
- "//third_party/ffmpeg",
Slava Chigrin 2015/01/20 18:25:20 Fixed by https://gerrit.chromium.org/gerrit/#/c/73
- "//third_party/leveldatabase",
- "//third_party/libjingle",
- "//third_party/usrsctp",
- "//third_party/webrtc",
Slava Chigrin 2015/01/20 18:25:19 WebRTC issues was fixed in few CL in their repo, l
- "//ui/accessibility",
"//ui/app_list",
"//ui/aura",
"//ui/keyboard",
- "//ui/native_theme",
"//ui/snapshot",
- "//ui/surface",
- "//ui/touch_selection",
"//ui/views",
"//ui/views/controls/webview",
"//ui/web_dialogs",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698