Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 840173005: Enable more targets in Windows GN build. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable more targets in Windows GN build. Committed: https://crrev.com/7aaefa6a261175c037398eb2775c508e1df577a0 Cr-Commit-Position: refs/heads/master@{#312291}

Patch Set 1 #

Patch Set 2 : Better list of enabled targets. #

Patch Set 3 : Enable more targets. #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M BUILD.gn View 1 2 2 chunks +1 line, -24 lines 5 comments Download

Messages

Total messages: 7 (2 generated)
Slava Chigrin
Enable more targets for build on bots to avoid their accidental breakage. Windows GN try ...
5 years, 11 months ago (2015-01-20 18:25:20 UTC) #2
brettw
lgtm
5 years, 11 months ago (2015-01-20 21:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840173005/40001
5 years, 11 months ago (2015-01-20 21:41:09 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-20 22:50:48 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 22:51:42 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7aaefa6a261175c037398eb2775c508e1df577a0
Cr-Commit-Position: refs/heads/master@{#312291}

Powered by Google App Engine
This is Rietveld 408576698