Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 840163004: Enable NetworkConnectionHandler and AutoConnectHandler unittests in debug. (Closed)

Created:
5 years, 11 months ago by pneubeck (no reviews)
Modified:
5 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NetworkConnectionHandler and AutoConnectHandler unittests in debug. Speed improvements by using smaller certs/keys and probably because of the simpler pem/pk8 files instead of the pkcs12 should make these tests again fast enough for debug bots. While there, replace usage of ScopedTestNSSChromeOSUser by the simpler ScopedTestNSSDB and remove the dependency on nss_util_internal.h. BUG=418369 Committed: https://crrev.com/eb1f1be18cdec48c679fdc5d09f15336d020cd12 Cr-Commit-Position: refs/heads/master@{#312349}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -75 lines) Patch
M chromeos/network/auto_connect_handler_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 10 chunks +39 lines, -70 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pneubeck (no reviews)
ptal (see for example https://codereview.chromium.org/845533002/, which did a similar change)
5 years, 11 months ago (2015-01-09 09:26:18 UTC) #3
pneubeck (no reviews)
one more of these certificate cleanups in unit tests.
5 years, 11 months ago (2015-01-19 08:34:23 UTC) #5
stevenjb
hooray, lgtm.
5 years, 11 months ago (2015-01-20 21:37:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840163004/20001
5 years, 11 months ago (2015-01-21 08:31:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-21 14:15:02 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:16:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb1f1be18cdec48c679fdc5d09f15336d020cd12
Cr-Commit-Position: refs/heads/master@{#312349}

Powered by Google App Engine
This is Rietveld 408576698