sky/engine/core/html/HTMLContentElement.cpp - Issue 840163003: Make SelectorChecker a const operation over element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/HTMLContentElement.cpp

Issue 840163003: Make SelectorChecker a const operation over element. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/HTMLContentElement.cpp

diff --git a/sky/engine/core/html/HTMLContentElement.cpp b/sky/engine/core/html/HTMLContentElement.cpp

index 2c3a0cde8f3af935cb1a45a3d4ae0ef4c8431fbe..4797f3ea79c666942f2b5167c73006d7b44f973a 100644

--- a/sky/engine/core/html/HTMLContentElement.cpp

+++ b/sky/engine/core/html/HTMLContentElement.cpp

@@ -110,7 +110,7 @@ bool HTMLContentElement::validateSelect() const

static inline bool checkOneSelector(const CSSSelector& selector, const Vector<RawPtr<Node>, 32>& siblings, int nth)

{

Element* element = toElement(siblings[nth]);

- SelectorChecker selectorChecker(element->document(), SelectorChecker::QueryingRules);

+ SelectorChecker selectorChecker;

SelectorChecker::SelectorCheckingContext context(selector, element);

return selectorChecker.match(context);

}