Make SelectorChecker a const operation over element.

Make SelectorChecker a const operation over element.

We now store the bits about what was matched inside the SelectorChecker
and map them to operations that mutate the style after matching the
selector. This eliminates the SelectorChecker::Mode.

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c405ab067f2cb407d56938865f065d03e6eac0e4

[esprehn, 2015-01-09 02:02:01]

esprehn@chromium.org changed reviewers:
+ ojan@chromium.org

[eseidel1, 2015-01-09 02:04:16]

eseidel@google.com changed reviewers:
+ eseidel@google.com

[eseidel1, 2015-01-09 02:04:17]

https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
File sky/engine/core/css/SelectorChecker.cpp (left):

https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
sky/engine/core/css/SelectorChecker.cpp:274: if (m_mode == SharingRules)
Do we care about removal of this early-out?

[ojan, 2015-01-09 02:05:31]

ojan@chromium.org changed reviewers:
- eseidel@google.com

[ojan, 2015-01-09 02:05:31]

lgtm

[esprehn, 2015-01-09 02:06:16]

Committed patchset #1 (id:1) manually as
c405ab067f2cb407d56938865f065d03e6eac0e4 (presubmit successful).

[esprehn, 2015-01-09 02:07:00]

On 2015/01/09 at 02:04:17, eseidel wrote:
>
https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
> File sky/engine/core/css/SelectorChecker.cpp (left):
> 
>
https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
> sky/engine/core/css/SelectorChecker.cpp:274: if (m_mode == SharingRules)
> Do we care about removal of this early-out?

We never actually set SharingRules now, so it didn't matter. This was because we
used to actually try matching rules inside the SharedStyleFinder.