Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 840163003: Make SelectorChecker a const operation over element. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make SelectorChecker a const operation over element. We now store the bits about what was matched inside the SelectorChecker and map them to operations that mutate the style after matching the selector. This eliminates the SelectorChecker::Mode. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c405ab067f2cb407d56938865f065d03e6eac0e4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M sky/engine/core/css/ElementRuleCollector.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/ElementRuleCollector.cpp View 2 chunks +13 lines, -4 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.h View 1 chunk +15 lines, -12 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 8 chunks +15 lines, -24 lines 1 comment Download
M sky/engine/core/dom/Element.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/SelectorQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLContentElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
esprehn
5 years, 11 months ago (2015-01-09 02:02:02 UTC) #2
eseidel1
https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/SelectorChecker.cpp File sky/engine/core/css/SelectorChecker.cpp (left): https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/SelectorChecker.cpp#oldcode274 sky/engine/core/css/SelectorChecker.cpp:274: if (m_mode == SharingRules) Do we care about removal ...
5 years, 11 months ago (2015-01-09 02:04:17 UTC) #4
ojan
lgtm
5 years, 11 months ago (2015-01-09 02:05:31 UTC) #6
esprehn
Committed patchset #1 (id:1) manually as c405ab067f2cb407d56938865f065d03e6eac0e4 (presubmit successful).
5 years, 11 months ago (2015-01-09 02:06:16 UTC) #7
esprehn
5 years, 11 months ago (2015-01-09 02:07:00 UTC) #8
Message was sent while issue was closed.
On 2015/01/09 at 02:04:17, eseidel wrote:
>
https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
> File sky/engine/core/css/SelectorChecker.cpp (left):
> 
>
https://codereview.chromium.org/840163003/diff/1/sky/engine/core/css/Selector...
> sky/engine/core/css/SelectorChecker.cpp:274: if (m_mode == SharingRules)
> Do we care about removal of this early-out?

We never actually set SharingRules now, so it didn't matter. This was because we
used to actually try matching rules inside the SharedStyleFinder.

Powered by Google App Engine
This is Rietveld 408576698