Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 84013003: linux_aura: Install language packs needed for testing. (Closed)

Created:
7 years, 1 month ago by Elliot Glaysher
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

linux_aura: Install language packs needed for testing. This modifies install-build-deps.sh to require language packs needed for running browser_tests. This also corrects a typo in locale_tests_browsertest.cc where we wanted a '_' instead of a '-'. BUG=316716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/install-build-deps.sh View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/locale_tests_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
7 years, 1 month ago (2013-11-22 20:54:03 UTC) #1
Lei Zhang
lgtm
7 years, 1 month ago (2013-11-22 21:17:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/84013003/1
7 years, 1 month ago (2013-11-22 22:53:09 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 01:37:50 UTC) #4
Message was sent while issue was closed.
Change committed as 236908

Powered by Google App Engine
This is Rietveld 408576698