Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 8401034: Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression. (Closed)

Created:
9 years, 1 month ago by vsevik
Modified:
9 years, 1 month ago
Reviewers:
vsevik
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression. https://bugs.webkit.org/show_bug.cgi?id=70718 Reviewed by Pavel Feldman. Source/WebCore: Test: inspector/debugger/watch-expressions-panel-switch.html * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): LayoutTests: * inspector/debugger/error-in-watch-expressions.html: * inspector/debugger/watch-expressions-panel-switch-expected.txt: Added. * inspector/debugger/watch-expressions-panel-switch.html: Added. * platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added. BUG=101496 TBR=vsevik@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M LayoutTests/inspector/debugger/error-in-watch-expressions.html View 1 chunk +11 lines, -2 lines 0 comments Download
A + LayoutTests/inspector/debugger/watch-expressions-panel-switch.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/inspector/front-end/ScriptsPanel.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
vsevik
9 years, 1 month ago (2011-10-27 15:45:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698