Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 840043004: Add trace rerun options to benchmark and pass them through chartjson. (Closed)

Created:
5 years, 11 months ago by shatch
Modified:
5 years, 11 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add trace rerun options to benchmark and pass them through chartjson. After discussion with Annie/Dave/Fadi/Kari and myself, seems like we settled on not exposing an arbitrary # of new command lines. Rather, there'd be an optional param to rerun with extra tracing categories enabled. The benchmark would specify that there's a debug option available, and has a way of customizing the exact categories it needs. Example of v8 benchmark modified: class V8GarbageCollectionCases(benchmark.Benchmark): """Measure V8 metrics on the garbage collection cases.""" def CreateTimelineBasedMeasurementOptions(self): # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become # available in the 'benchmark' category. # This can theoretically be handled now by the "default" override return timeline_based_measurement.Options() @classmethod def HasBenchmarkTraceRerunDebugOption(cls): return True def SetupBenchmarkDefaultTraceRerunOptions(self, tbm_options): tbm_options.ExtendTraceCategoryFilters(['v8']) def SetupBenchmarkDebugTraceRerunOptions(self, tbm_options): tbm_options.ExtendTraceCategoryFilters(['*']) BUG= Committed: https://crrev.com/7b1e7c024524e088fa623746c6dc82ad2e29b60c Cr-Commit-Position: refs/heads/master@{#313080}

Patch Set 1 #

Patch Set 2 : After discussion. #

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M tools/telemetry/telemetry/benchmark.py View 1 2 5 chunks +46 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/results/chart_json_output_formatter.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shatch
ptal, hopefully follows what we discussed offline
5 years, 11 months ago (2015-01-19 22:23:40 UTC) #2
sullivan
lgtm
5 years, 11 months ago (2015-01-21 21:02:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840043004/40001
5 years, 11 months ago (2015-01-26 14:58:59 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-26 17:00:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 17:01:03 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b1e7c024524e088fa623746c6dc82ad2e29b60c
Cr-Commit-Position: refs/heads/master@{#313080}

Powered by Google App Engine
This is Rietveld 408576698