Implement mocks for identity and host-list, add a browser test to test the app in various failure m…

chrome/test/remoting/remote_desktop_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/remoting/remote_desktop_browsertest.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/path_service.h"
@@ skipping 433 matching lines @@
     VerifyChromotingLoaded(false);
     if (is_unpacked())
       InstallChromotingAppUnpacked();
     else
       InstallChromotingAppCrx();
   }
 
   VerifyChromotingLoaded(true);
 }
 
+void RemoteDesktopBrowserTest::LoadBrowserTestJavaScript() {
+  content::WebContents* content = app_web_content();

[kelvinp, 2015/01/08 22:54:40]

As per your suggestion in the other CL
https://codereview.chromium.org/838543002/
I am thinking of getting rid of app_web_content() have LaunchChromotingApp
returns a content::WebContent* of the app.
This will make our code cleaner for test that involves two instances of the
Chromoting app.

In light of that, I think LoadBrowserTestJavaScript should takes the
content::WebContents* as a parameter.

[Jamie, 2015/01/08 23:43:08]

Done.

+  LoadScript(content, FILE_PATH_LITERAL("browser_test.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_client_plugin.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_host_list_api.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_identity.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_oauth2_api.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_session_connector.js"));
+  LoadScript(content, FILE_PATH_LITERAL("mock_signal_strategy.js"));
+  LoadScript(content, FILE_PATH_LITERAL("timeout_waiter.js"));
+}
+
 void RemoteDesktopBrowserTest::Cleanup() {
   // TODO(weitaosu): Remove this hack by blocking on the appropriate
   // notification.
   // The browser may still be loading images embedded in the webapp. If we
   // uinstall it now those load will fail.
   ASSERT_TRUE(TimeoutWaiter(base::TimeDelta::FromSeconds(2)).Wait());
 
   if (!NoCleanup()) {
     UninstallChromotingApp();
     VerifyChromotingLoaded(false);
   }
 
   // TODO(chaitali): Remove this additional timeout after we figure out
   // why this is needed for the v1 app to work.
   // Without this timeout the test fail with a "CloseWebContents called for
   // tab not in our strip" error for the v1 app.
   ASSERT_TRUE(TimeoutWaiter(base::TimeDelta::FromSeconds(2)).Wait());
 }
 
 void RemoteDesktopBrowserTest::SetUpTestForMe2Me() {
   VerifyInternetAccess();
   Install();
   LaunchChromotingApp(false);
+  LoadBrowserTestJavaScript();
   Auth();
-  LoadScript(app_web_content(), FILE_PATH_LITERAL("browser_test.js"));
   ExpandMe2Me();
   // The call to EnsureRemoteConnectionEnabled() does a PIN reset.
   // This causes the test to fail because of a recent bug:
   // crbug.com/430676
   // TODO(anandc): Reactivate this call after above bug is fixed.
   //EnsureRemoteConnectionEnabled();
 }
 
 void RemoteDesktopBrowserTest::Auth() {
   // For this test, we must be given the user-name and password.
@@ skipping 406 matching lines @@
 // static
 bool RemoteDesktopBrowserTest::IsEnabled(
     content::WebContents* client_web_content,
     const std::string& element_name) {
   return !ExecuteScriptAndExtractBool(
     client_web_content,
     "document.getElementById(\"" + element_name + "\").disabled");
 }
 
 }  // namespace remoting