Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 840023002: Revert of Revert of Turn on job-based recompilation (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Turn on job-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/791033007/) Reason for revert: attempt reland after landing a fix Original issue's description: > Revert of Turn on job-based recompilation (patchset #2 id:20001 of https://codereview.chromium.org/832183004/) > > Reason for revert: > revert > > Original issue's description: > > Turn on job-based recompilation > > > > BUG=v8:3608 > > LOG=y > > R=yangguo@chromium.org > > > > Committed: https://crrev.com/715552409b4a08504301cf1ad4cb2e45a815f01b > > Cr-Commit-Position: refs/heads/master@{#25972} > > TBR=yangguo@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=v8:3608 > > Committed: https://crrev.com/28a5a4865183769cbed9d42ad3fdc1b1d8bae3a3 > Cr-Commit-Position: refs/heads/master@{#25975} TBR=yangguo@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3608 Committed: https://crrev.com/b4bc9c1a3a7d03dee0b3dd6460414085f79cd36e Cr-Commit-Position: refs/heads/master@{#25994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert of Turn on job-based recompilation
5 years, 11 months ago (2015-01-08 13:15:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/840023002/1
5 years, 11 months ago (2015-01-08 13:15:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 13:16:01 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4bc9c1a3a7d03dee0b3dd6460414085f79cd36e Cr-Commit-Position: refs/heads/master@{#25994}
5 years, 11 months ago (2015-01-08 13:16:12 UTC) #4
Yang
On 2015/01/08 13:16:01, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) lgtm.
5 years, 11 months ago (2015-01-08 13:16:13 UTC) #5
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-08 14:30:08 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/832103003/ by jochen@chromium.org.

The reason for reverting is: still doesn't work.

Powered by Google App Engine
This is Rietveld 408576698