Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 839983002: Adding "target_frame_rate" variable in lieu of "max_frame_rate" for FrameReceiverConfig (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
Reviewers:
xhwang, miu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding "target_frame_rate" variable in lieu of "max_frame_rate" for FrameReceiverConfig structure. BUG=447205 Committed: https://crrev.com/080a59d7e7691befd122564c73bb353050e3c1dc Cr-Commit-Position: refs/heads/master@{#310600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M media/cast/cast_config.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/frame_receiver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/receiver/frame_receiver_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/cast/test/cast_benchmarks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/default_config.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
anujsharma
PTAL
5 years, 11 months ago (2015-01-08 14:20:26 UTC) #3
anujsharma
PTAL
5 years, 11 months ago (2015-01-08 14:20:26 UTC) #4
xhwang
I am not familiar with this code. I'll defer to miu@ to finish the review.
5 years, 11 months ago (2015-01-08 17:01:29 UTC) #5
miu
lgtm
5 years, 11 months ago (2015-01-08 19:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839983002/1
5 years, 11 months ago (2015-01-08 19:52:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 21:21:36 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 21:23:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/080a59d7e7691befd122564c73bb353050e3c1dc
Cr-Commit-Position: refs/heads/master@{#310600}

Powered by Google App Engine
This is Rietveld 408576698