Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: pkg/analyzer/test/generated/incremental_resolver_test.dart

Issue 839913002: Validate incremental resolutions results if requested. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/incremental_resolver_test.dart
diff --git a/pkg/analyzer/test/generated/incremental_resolver_test.dart b/pkg/analyzer/test/generated/incremental_resolver_test.dart
index 16ecdd9b27c5cd81f952e78f249ebbed68f07204..302ecab110516a4d56f0b16c3d6f3cbf60f5b05c 100644
--- a/pkg/analyzer/test/generated/incremental_resolver_test.dart
+++ b/pkg/analyzer/test/generated/incremental_resolver_test.dart
@@ -2289,7 +2289,11 @@ class B {
LibraryElement library = resolve(source);
fullNewUnit = resolveCompilationUnit(source, library);
}
- assertSameResolution(unit, fullNewUnit, fail);
+ try {
+ assertSameResolution(unit, fullNewUnit);
+ } on IncrementalResolutionMismatch catch (mismatch) {
+ fail(mismatch.message);
+ }
// errors
List<AnalysisError> newFullErrors =
analysisContext.getErrors(source).errors;
@@ -3113,7 +3117,11 @@ f3() {
LibraryElement library = resolve(source);
CompilationUnit fullNewUnit = resolveCompilationUnit(source, library);
// Validate that "incremental" and "full" units have the same resolution.
- assertSameResolution(newUnit, fullNewUnit, fail);
+ try {
+ assertSameResolution(newUnit, fullNewUnit, validateTypes: true);
+ } on IncrementalResolutionMismatch catch (mismatch) {
+ fail(mismatch.message);
+ }
_assertEqualTokens(newUnit, fullNewUnit);
List<AnalysisError> newFullErrors =
analysisContext.getErrors(source).errors;

Powered by Google App Engine
This is Rietveld 408576698