webkit/glue/webmediaplayer_impl.h - Issue 8399023: Fire canplaythrough event at the proper time for audio/video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webmediaplayer_impl.h

Issue 8399023: Fire canplaythrough event at the proper time for audio/video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move canplaythrough logic into pipeline; fix other stuff Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/webmediaplayer_impl.h

diff --git a/webkit/glue/webmediaplayer_impl.h b/webkit/glue/webmediaplayer_impl.h

index ea19d583524a5d58bf4691cee787cc0e738efea0..db426bc65db4c1c9f3af4cd43d8f370d1ca46799 100644

--- a/webkit/glue/webmediaplayer_impl.h

+++ b/webkit/glue/webmediaplayer_impl.h

@@ -196,7 +196,7 @@ class WebMediaPlayerImpl

void OnPipelineSeek(media::PipelineStatus status);

void OnPipelineEnded(media::PipelineStatus status);

void OnPipelineError(media::PipelineStatus error);

- void OnNetworkEvent(bool is_downloading_data);

+ void OnNetworkEvent(media::NetworkEvent type);

void OnDemuxerOpened();

private:

@@ -271,6 +271,8 @@ class WebMediaPlayerImpl

bool incremented_externally_allocated_memory_;

+ bool can_play_through_;

DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);

};