Fire canplaythrough event at the proper time for audio/video

media/base/pipeline.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The pipeline is the public API clients use for playing back media.  Clients
 // provide a filter collection containing the filters they want the pipeline to
 // use to render media.
 
 #ifndef MEDIA_BASE_PIPELINE_H_
 #define MEDIA_BASE_PIPELINE_H_
@@ skipping 16 matching lines @@
       video_frames_decoded(0),
       video_frames_dropped(0) {
   }
 
   uint32 audio_bytes_decoded;  // Should be uint64?
   uint32 video_bytes_decoded;  // Should be uint64?
   uint32 video_frames_decoded;
   uint32 video_frames_dropped;
 };
 
+enum NetworkEvent {
+  DOWNLOAD_CONTINUED,
+  DOWNLOAD_PAUSED,
+  CAN_PLAY_THROUGH
+};
+
 class FilterCollection;
 
 class MEDIA_EXPORT Pipeline : public base::RefCountedThreadSafe<Pipeline> {
  public:
   // Callback that executes when a network event occurrs.
-  // The parameter represents the state of network activity: true if the network
-  // is downloading data, false if it is not. If the callback never runs, it is
-  // assumed the network is not downloading data.
-  typedef base::Callback<void(bool)> NetworkEventCB;
+  // The parameter specifies the type of event that is being signaled.
+  typedef base::Callback<void(NetworkEvent)> NetworkEventCB;

[acolwell GONE FROM CHROMIUM, 2011/11/09 00:50:22]

I figured this bool wouldn't last long. ;)

[vrk (LEFT CHROMIUM), 2011/11/11 02:51:06]

:)

 
   // Initializes pipeline. Pipeline takes ownership of all callbacks passed
   // into this method.
   // |ended_callback| will be executed when the media reaches the end.
   // |error_callback_| will be executed upon an error in the pipeline.
   // |network_callback_| will be executed when there's a network event.
   virtual void Init(const PipelineStatusCB& ended_callback,
                     const PipelineStatusCB& error_callback,
                     const NetworkEventCB& network_callback) = 0;
 
@@ skipping 112 matching lines @@
 
  protected:
   // Only allow ourselves to be deleted by reference counting.
   friend class base::RefCountedThreadSafe<Pipeline>;
   virtual ~Pipeline() {}
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_PIPELINE_H_