Fixed compiler so that it passes Switch1NegativeTest.dart.

Fixed compiler so that it passes Switch1NegativeTest.dart. In the process of
fixing SwitchFallthruTest as well, but I need to fix generated constructors in frog first.

TBR
Committed: https://code.google.com/p/dart/source/detail?r=840

[jimhug, 2011-10-27 17:45:11]

This is a great start, but it still needs some work - and at least minimal flow
analysis should be a high priority.  Luckily, that's what followup CLs are for
<smile>.

http://codereview.chromium.org/8399010/diff/5001/frogsh
File frogsh (right):

http://codereview.chromium.org/8399010/diff/5001/frogsh#newcode545
frogsh:545: return -1.000000/*-1*/;
It looks like you didn't do a "true" selfhost build here?  If you build with
frogsh --out=frogsh frog.dart, I would expect better number formatting and for
these to just show up as -1.

http://codereview.chromium.org/8399010/diff/5001/frogsh#newcode2004
frogsh:2004: $throw(new FallThroughError("./leg/scanner/scanner.dart", 65))
Hopefully, this code - as well as our other similar tokenizer code below helps
capture the need for some minimal flow analysis to keep the generated code small
and readable?

http://codereview.chromium.org/8399010/diff/5001/gen.dart
File gen.dart (right):

http://codereview.chromium.org/8399010/diff/5001/gen.dart#newcode1355
gen.dart:1355: stmt.visit(this);
This needs to do some sort of minimal checking for flow here.  In particular, we
shouldn't be adding the throw immediately after a break of a return.

http://codereview.chromium.org/8399010/diff/5001/lib/corelib.dart
File lib/corelib.dart (right):

http://codereview.chromium.org/8399010/diff/5001/lib/corelib.dart#newcode94
lib/corelib.dart:94: class FallThroughError {
This should be causing a validation error - you can't initialize finals after
initializers have run.  Try this version for the constructor:

const FallThroughError(this.url, this.line);

http://codereview.chromium.org/8399010/diff/5001/tests/frog/frog.status
File tests/frog/frog.status (left):

http://codereview.chromium.org/8399010/diff/5001/tests/frog/frog.status#oldco...
tests/frog/frog.status:175: Switch1NegativeTest: Fail
Yay!

[Emily Fortuna, 2011-10-27 17:59:03]

http://codereview.chromium.org/8399010/diff/5001/frogsh
File frogsh (right):

http://codereview.chromium.org/8399010/diff/5001/frogsh#newcode2004
frogsh:2004: $throw(new FallThroughError("./leg/scanner/scanner.dart", 65))
Yeah, I've reversed this change in r843. Will make a better solution for the
next CL.

On 2011/10/27 17:45:11, jimhug wrote:
> Hopefully, this code - as well as our other similar tokenizer code below helps
> capture the need for some minimal flow analysis to keep the generated code
small
> and readable?

http://codereview.chromium.org/8399010/diff/5001/gen.dart
File gen.dart (right):

http://codereview.chromium.org/8399010/diff/5001/gen.dart#newcode1355
gen.dart:1355: stmt.visit(this);
On 2011/10/27 17:45:11, jimhug wrote:
> This needs to do some sort of minimal checking for flow here.  In particular,
we
> shouldn't be adding the throw immediately after a break of a return.

Done in the next CL.

http://codereview.chromium.org/8399010/diff/5001/lib/corelib.dart
File lib/corelib.dart (right):

http://codereview.chromium.org/8399010/diff/5001/lib/corelib.dart#newcode94
lib/corelib.dart:94: class FallThroughError {
This was left over when when I was testing the dart->js constructor issue. It
has been taken out.

On 2011/10/27 17:45:11, jimhug wrote:
> This should be causing a validation error - you can't initialize finals after
> initializers have run.  Try this version for the constructor:
> 
> const FallThroughError(this.url, this.line);