Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 839893005: Vector-based KeyedLoadIC MISS logic needs improvement. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector-based KeyedLoadIC MISS logic needs improvement. Two issues: 1) We would trace the MISS two times on vector-based KeyedLoadIC with a string key in MEGAMORPHIC state. 2) There was a confusing asymmetry in the handling of going GENERIC. This change makes it the same whether --vector-ics is on or not. BUG= Committed: https://crrev.com/b3b9d20ad76400f4c61748072ddda033655b4484 Cr-Commit-Position: refs/heads/master@{#26105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M src/ic/ic.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 8 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, this CL cleans up some strange logic around changing to the GENERIC state ...
5 years, 11 months ago (2015-01-16 12:25:02 UTC) #2
Yang
lgtm.
5 years, 11 months ago (2015-01-16 12:33:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839893005/1
5 years, 11 months ago (2015-01-16 13:01:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 13:28:27 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 13:28:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3b9d20ad76400f4c61748072ddda033655b4484
Cr-Commit-Position: refs/heads/master@{#26105}

Powered by Google App Engine
This is Rietveld 408576698