build/android/pylib/device/device_utils.py - Issue 839893004: Refactor test scripts for android to improve performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/device_utils.py

Issue 839893004: Refactor test scripts for android to improve performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skip checking package on JBMR2 or above Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/device/device_utils.py

diff --git a/build/android/pylib/device/device_utils.py b/build/android/pylib/device/device_utils.py

index fe9d2c64324ecb378bf43b4c63aa8e1d13a94acc..a4ddef1328057f6376175ae4f448e8eb314420c3 100644

--- a/build/android/pylib/device/device_utils.py

+++ b/build/android/pylib/device/device_utils.py

@@ -634,9 +634,12 @@ class DeviceUtils(object):

CommandTimeoutError on timeout.

DeviceUnreachableError on missing device.

"""

- # Check that the package exists before clearing it. Necessary because

- # calling pm clear on a package that doesn't exist may never return.

- if self.GetApplicationPath(package):

+ # Check that the package exists before clearing it for android builds below

+ # JB MR2. Necessary because calling pm clear on a package that doesn't exist

+ # may never return.

+ if ((self.build_version_sdk >=

+ constants.ANDROID_SDK_VERSION_CODES.JELLY_BEAN_MR2)

+ or self.GetApplicationPath(package)):

self.RunShellCommand(['pm', 'clear', package], check_return=True)

@decorators.WithTimeoutAndRetriesFromInstance()

« no previous file with comments | « no previous file | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »