Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 839883003: Add repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add repro GM for GPU clipped-AA vs. non-AA drawRect discrepancy In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies. BUG=423834 Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff Committed: https://skia.googlesource.com/skia/+/028b98a08072bd1764936e47c54fa2da5cf92744

Patch Set 1 #

Patch Set 2 : Add suppressions #

Patch Set 3 : Reduce to reproducing GM #

Patch Set 4 : Fix nuisance change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -11 lines) Patch
A gm/clipdrawdraw.cpp View 1 chunk +92 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
robertphillips
5 years, 11 months ago (2015-01-09 20:38:59 UTC) #3
robertphillips
5 years, 11 months ago (2015-01-12 13:57:23 UTC) #4
bsalomon
On 2015/01/12 13:57:23, robertphillips wrote: lgtm
5 years, 11 months ago (2015-01-12 22:17:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839883003/20001
5 years, 11 months ago (2015-01-12 23:41:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff
5 years, 11 months ago (2015-01-12 23:50:40 UTC) #8
robertphillips
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/847033002/ by robertphillips@google.com. ...
5 years, 11 months ago (2015-01-13 02:25:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839883003/60001
5 years, 11 months ago (2015-01-14 17:34:28 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 17:44:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/028b98a08072bd1764936e47c54fa2da5cf92744

Powered by Google App Engine
This is Rietveld 408576698