Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 839813002: [turbofan] Fix bit representation of NumberConstant. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bit representation of NumberConstant. TEST=mjsunit/compiler/regress-bit-number-constant Committed: https://crrev.com/d1c1a3c48f1a5aa3e14a4bea4930e769856c0e83 Cr-Commit-Position: refs/heads/master@{#25979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/compiler/representation-change.h View 1 chunk +7 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-bit-number-constant.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-07 15:15:22 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-07 15:16:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839813002/1
5 years, 11 months ago (2015-01-07 15:16:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 15:44:22 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:44:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1c1a3c48f1a5aa3e14a4bea4930e769856c0e83
Cr-Commit-Position: refs/heads/master@{#25979}

Powered by Google App Engine
This is Rietveld 408576698