Issue 839783002: Ignore src candidates when looking for already in-cache resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 839783002: Ignore src candidates when looking for already in-cache resources (Closed)

Created:
5 years, 11 months ago by Yoav Weiss

Modified:
5 years, 11 months ago

Reviewers:
Mike West

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Ignore src candidates when looking for already in-cache resources Considering src based candidates when looking for in-cache candidates can result in no resource being downloaded, and the src resource remaining as the displayed image. That's contrary to the spec, where the src resource should not be part of the selection algorithm if `w` descriptors are present. This CL fixes that. BUG=431862 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187966

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -3 lines)			Patch
A	LayoutTests/fast/dom/HTMLImageElement/image-src-added-srcset-w-descriptors.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLImageElement/image-src-added-srcset-w-descriptors-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/parser/HTMLSrcsetParser.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839783002/1

5 years, 11 months ago (2015-01-07 12:40:19 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-07 13:39:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187966

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages