Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 839763002: fix builds with vpx and/or ffmpeg disabled (Closed)

Created:
5 years, 11 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix builds with vpx and/or ffmpeg disabled If media_use_libvpx==0 then we should not include any libvpx headers. And similarly for ffmpeg. Followup to https://codereview.chromium.org/783003002 BUG=416570 Committed: https://crrev.com/10406b9bcce7a8cb744a7ba118b11450444afb16 Cr-Commit-Position: refs/heads/master@{#310383}

Patch Set 1 #

Patch Set 2 : fix gn build too #

Patch Set 3 : fix builds with ffmpeg disabled also #

Total comments: 6

Patch Set 4 : add fixups #

Total comments: 6

Patch Set 5 : last fixups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M media/BUILD.gn View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M media/filters/default_renderer_factory.cc View 1 2 3 4 3 chunks +12 lines, -1 line 0 comments Download
M media/media.gyp View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Mostyn Bramley-Moore
@xhwang: please take a look at this tiny fixup.
5 years, 11 months ago (2015-01-07 10:40:29 UTC) #2
xhwang
https://codereview.chromium.org/839763002/diff/40001/media/BUILD.gn File media/BUILD.gn (right): https://codereview.chromium.org/839763002/diff/40001/media/BUILD.gn#newcode40 media/BUILD.gn:40: } Add MEDIA_DISABLE_FFMPEG here? See comments below for where ...
5 years, 11 months ago (2015-01-07 17:12:31 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/839763002/diff/40001/media/BUILD.gn File media/BUILD.gn (right): https://codereview.chromium.org/839763002/diff/40001/media/BUILD.gn#newcode40 media/BUILD.gn:40: } On 2015/01/07 17:12:30, xhwang wrote: > Add MEDIA_DISABLE_FFMPEG ...
5 years, 11 months ago (2015-01-07 19:29:53 UTC) #4
xhwang
lgtm % comments https://codereview.chromium.org/839763002/diff/60001/media/filters/default_renderer_factory.cc File media/filters/default_renderer_factory.cc (right): https://codereview.chromium.org/839763002/diff/60001/media/filters/default_renderer_factory.cc#newcode13 media/filters/default_renderer_factory.cc:13: #endif // !MEDIA_DISABLE_FFMPEG nit: Usually we ...
5 years, 11 months ago (2015-01-07 20:42:30 UTC) #5
Mostyn Bramley-Moore
https://codereview.chromium.org/839763002/diff/60001/media/filters/default_renderer_factory.cc File media/filters/default_renderer_factory.cc (right): https://codereview.chromium.org/839763002/diff/60001/media/filters/default_renderer_factory.cc#newcode13 media/filters/default_renderer_factory.cc:13: #endif // !MEDIA_DISABLE_FFMPEG On 2015/01/07 20:42:30, xhwang wrote: > ...
5 years, 11 months ago (2015-01-07 20:54:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839763002/80001
5 years, 11 months ago (2015-01-07 20:56:32 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-07 22:02:29 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 22:03:56 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/10406b9bcce7a8cb744a7ba118b11450444afb16
Cr-Commit-Position: refs/heads/master@{#310383}

Powered by Google App Engine
This is Rietveld 408576698