Style fixes in //ios

Style fixes in //ios

Committed: https://crrev.com/e7a9e026026dc73b96a5c20b874e58ba57d3a42b
Cr-Commit-Position: refs/heads/master@{#310825}

[droger, 2015-01-09 10:19:40]

Patchset #1 (id:1) has been deleted

[droger, 2015-01-09 10:27:17]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-01-09 10:35:31]

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
File ios/chrome/browser/translate/before_translate_infobar_controller.mm
(right):

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:219: UIView*
blockLanguagePicker = _languagePicker.get();
can you make blockNavigationBar and blockLanguagePicker scoped_nsobject<>?

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:219: UIView*
blockLanguagePicker = _languagePicker.get();
can you make blockNavigationBar and blockLanguagePicker scoped_nsobject<>?

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:228:
[_languageSelectionView removeFromSuperview];
nit: maybe make it explicit that self is retained by doing
self->_languageSelectionView?

https://codereview.chromium.org/839733004/diff/20001/ios/web/public/web_state...
File ios/web/public/web_state/web_state.h (right):

https://codereview.chromium.org/839733004/diff/20001/ios/web/public/web_state...
ios/web/public/web_state/web_state.h:72: // nullptr.
s/nullptr/null/ in comments

https://codereview.chromium.org/839733004/diff/20001/ios/web/public/web_state...
File ios/web/public/web_state/web_state_user_data.h (right):

https://codereview.chromium.org/839733004/diff/20001/ios/web/public/web_state...
ios/web/public/web_state/web_state_user_data.h:41: // of the type was attached,
returns nullptr.
s/nullptr/null/ in comments

[droger, 2015-01-09 13:17:52]

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
File ios/chrome/browser/translate/before_translate_infobar_controller.mm
(right):

https://codereview.chromium.org/839733004/diff/20001/ios/chrome/browser/trans...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:228:
[_languageSelectionView removeFromSuperview];
On 2015/01/09 10:35:30, sdefresne wrote:
> nit: maybe make it explicit that self is retained by doing
> self->_languageSelectionView?

I changed the block to no longer retain self.

[droger, 2015-01-09 13:18:31]

The CQ bit was checked by droger@chromium.org

[droger, 2015-01-09 13:18:33]

The CQ bit was unchecked by droger@chromium.org

[sdefresne, 2015-01-09 13:47:58]

lgtm with nit

https://codereview.chromium.org/839733004/diff/60001/ios/chrome/browser/trans...
File ios/chrome/browser/translate/before_translate_infobar_controller.mm
(right):

https://codereview.chromium.org/839733004/diff/60001/ios/chrome/browser/trans...
ios/chrome/browser/translate/before_translate_infobar_controller.mm:339: [UIView
animateWithDuration:kPickerAnimationDurationInSeconds
nit: can you also change this block not to capture self?

[droger, 2015-01-09 18:01:22]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-01-09 18:02:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839733004/80001

[commit-bot: I haz the power, 2015-01-09 19:40:55]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-01-09 19:42:02]

Patchset 4 (id:??) landed as
https://crrev.com/e7a9e026026dc73b96a5c20b874e58ba57d3a42b
Cr-Commit-Position: refs/heads/master@{#310825}