Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 839733003: Image() constructor's arguments should not have default values (Closed)

Created:
5 years, 11 months ago by Jens Widell
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Image() constructor's arguments should not have default values Implementing them with [Default=Undefined] is equivalent to implementing them with zero as the default value, which is semi-correct; the created element's 'width' and 'height' IDL attributes should be zero. However, per spec, calling Image() without the arguments should create an element without the 'width' and 'height' content attributes, whereas calling Image() with the arguments should create an element with the content attributes, including if the argument values were zero. Thus we need to distinguish between no argument and argument being zero. BUG=253777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M LayoutTests/fast/js/custom-constructors-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/script-tests/custom-constructors.js View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +17 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jens Widell
PTAL
5 years, 11 months ago (2015-01-07 13:28:08 UTC) #2
haraken
LGTM, assuming the new behavior aligns with Firefox.
5 years, 11 months ago (2015-01-07 14:09:41 UTC) #3
Jens Widell
On 2015/01/07 14:09:41, haraken wrote: > LGTM, assuming the new behavior aligns with Firefox. Thanks ...
5 years, 11 months ago (2015-01-07 14:17:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839733003/1
5 years, 11 months ago (2015-01-07 14:18:18 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:29:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187973

Powered by Google App Engine
This is Rietveld 408576698