Issue 839603002: Revert "Remove SkPDFDocument and SkPDFDevice from the public headers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 839603002: Revert "Remove SkPDFDocument and SkPDFDevice from the public headers." (Closed)

Created:
5 years, 11 months ago by reed1

Modified:
5 years, 11 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert "Remove SkPDFDocument and SkPDFDevice from the public headers." This reverts commit 8b1f761365df6652ea9304b6572d2dd91917b9aa. BUG=skia: TBR= NOTRY=True NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/efdac514a9846e4ef32e1160fe7f2dae471cef39

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -466 lines)			Patch
M	gm/gmmain.cpp	View	3 chunks	+51 lines, -14 lines	0 comments	Download
M	gyp/pdf.gyp	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	gyp/pdf.gypi	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	include/pdf/SkPDFDevice.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	include/pdf/SkPDFDocument.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	src/pdf/SkPDFDevice.h	View	1 chunk	+0 lines, -339 lines	0 comments	Download
D	src/pdf/SkPDFDocument.h	View	1 chunk	+0 lines, -113 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839603002/1

5 years, 11 months ago (2015-01-06 17:54:01 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 17:54:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/efdac514a9846e4ef32e1160fe7f2dae471cef39