Issue 839583005: Comment out unused names in src/core/SkGlyphCache.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 839583005: Comment out unused names in src/core/SkGlyphCache.h (Closed)

Created:
5 years, 11 months ago by tomhudson

Modified:
5 years, 11 months ago

Reviewers:
Tom Hudson, djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Comment out unused names in src/core/SkGlyphCache.h Android violates our encapsulation and depends on this file; to keep their compiles clean they want us to hide the names of unused parameters. Follow-up to https://codereview.chromium.org/726923002/. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/f7be779e1d041b9c51f25349a8a9f8e3360d6dbc

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/core/SkGlyphCache.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839583005/1

5 years, 11 months ago (2015-01-06 20:50:31 UTC) #3

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 20:59:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f7be779e1d041b9c51f25349a8a9f8e3360d6dbc