Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/build.py

Issue 839543002: Revert "Build Observatory with runtime" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tools/create_resources.py ('k') | tools/canary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
diff --git a/tools/build.py b/tools/build.py
index ec0646bb1414484beff8a7ea6fd5e36e80c182da..b87084eb283607d543e62d964d885be763c0cca3 100755
--- a/tools/build.py
+++ b/tools/build.py
@@ -76,11 +76,6 @@ def BuildOptions():
help='Name of the devenv.com/msbuild executable on Windows (varies for '
'different versions of Visual Studio)',
default=vs_executable)
- result.add_option("--use-bootstrap-for-observatory",
- help='Use a stripped down Dart binary built on the host machine '
- 'for building Observatory. Necessary on Linux machines which have '
- 'libc incompatibilities with the prebuilt Dart binaries.',
- default=False, action="store_true")
return result
@@ -366,7 +361,7 @@ def NotifyBuildDone(build_config, success, start):
icon = 'info'
else:
icon = 'error'
- command = ("powershell -command \""
+ command = ("powershell -command \""
"[reflection.assembly]::loadwithpartialname('System.Windows.Forms')"
"| Out-Null;"
"[reflection.assembly]::loadwithpartialname('System.Drawing')"
@@ -389,8 +384,6 @@ def BuildOneConfig(options, target, target_os, mode, arch, override_tools):
global filter_xcodebuild_output
start_time = time.time()
os.environ['DART_BUILD_MODE'] = mode
- if options.use_bootstrap_for_observatory != False:
- os.environ['DART_USE_BOOTSTRAP_BIN'] = '1'
build_config = utils.GetBuildConf(mode, arch, target_os)
if HOST_OS == 'macos':
filter_xcodebuild_output = True
« no previous file with comments | « runtime/tools/create_resources.py ('k') | tools/canary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698