Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 839533004: Store serialized notification data as an Intent extra on Android. (Closed)

Created:
5 years, 11 months ago by Peter Beverloo
Modified:
5 years, 11 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store serialized notification data as an Intent extra on Android. When a displayed notification outlives the browser process, we need to be able to wake up the browser and re-create all required objects and data in order to fire the "notificationclick" event on the Service Worker associated with a notification. This patch serializes the notification data in a pickle, and passes it as an opaque byte array to the Java side, where it's stored in the Android intent. When the intent fires, we pass it back to C++ and unserialize the data there. BUG=90795, 432527 Committed: https://crrev.com/69231d50f63a58885e1da34ed756dfd3cda8d461 Cr-Commit-Position: refs/heads/master@{#310770}

Patch Set 1 #

Total comments: 14

Patch Set 2 : #

Patch Set 3 : add a pickle size limit #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 1 2 5 chunks +28 lines, -14 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 2 3 4 chunks +167 lines, -7 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_delegate.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Peter Beverloo
+dewittj, mvanouwerkerk and miguelg This is nowhere ready to land, it needs clean-ups, removal of ...
5 years, 11 months ago (2015-01-06 17:00:43 UTC) #2
Miguel Garcia
I like the idea very much, to the point that I'd like to discuss why ...
5 years, 11 months ago (2015-01-07 11:07:40 UTC) #3
Michael van Ouwerkerk
nice https://codereview.chromium.org/839533004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java (right): https://codereview.chromium.org/839533004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java#newcode128 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:128: if (!intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_DATA)) Wanna log something here? https://codereview.chromium.org/839533004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java#newcode145 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:145: ...
5 years, 11 months ago (2015-01-07 13:39:10 UTC) #4
Peter Beverloo
https://codereview.chromium.org/839533004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java (right): https://codereview.chromium.org/839533004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java#newcode128 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:128: if (!intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_DATA)) On 2015/01/07 11:07:40, Miguel Garcia wrote: > ...
5 years, 11 months ago (2015-01-07 15:16:30 UTC) #5
dewittj
main question is whether this pickle can live across version updates of Chrome, do we ...
5 years, 11 months ago (2015-01-07 21:23:53 UTC) #6
Peter Beverloo
On 2015/01/07 21:23:53, dewittj wrote: > main question is whether this pickle can live across ...
5 years, 11 months ago (2015-01-07 21:29:42 UTC) #7
Peter Beverloo
On 2015/01/07 21:29:42, Peter Beverloo wrote: > On 2015/01/07 21:23:53, dewittj wrote: > > main ...
5 years, 11 months ago (2015-01-09 13:35:20 UTC) #8
Miguel Garcia
lgtm
5 years, 11 months ago (2015-01-09 13:44:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839533004/60001
5 years, 11 months ago (2015-01-09 15:48:09 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-09 15:49:51 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 15:50:56 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/69231d50f63a58885e1da34ed756dfd3cda8d461
Cr-Commit-Position: refs/heads/master@{#310770}

Powered by Google App Engine
This is Rietveld 408576698