Add policy for blocking GCP printing.

Add policy for blocking GCP printing.


BUG=101389
TEST=On any platform use the appropriate policy mechanism to set CloudPrintSubmitEnabled to false.  Cloud print should no longer be available via built in print mechanisms


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107748

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108038

[Scott Byer, 2011-10-26 23:20:04]

Non-policy parts LGTM

On 2011/10/26 23:03:21, Albert Bodenhamer wrote:

[pastarmovj, 2011-10-27 09:01:23]

LGTM for the policy stuff with one comment in the code.

http://codereview.chromium.org/8395007/diff/14005/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/8395007/diff/14005/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler.cc:666: if
(!prefs->IsManagedPreference(prefs::kCloudPrintSubmitEnabled) ||
I don't think you need the IsManagedPreference check here. If it is not managed
it will be either left to its default value which is true or the user could
potentially write it in his Preferences file and set it to false in which case
although undocumented it will be valid way to locally disable GCP.

[Albert Bodenhamer, 2011-10-27 18:18:38]

Waiting for a last set of tries before I commit

http://codereview.chromium.org/8395007/diff/14005/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview_handler.cc (right):

http://codereview.chromium.org/8395007/diff/14005/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview_handler.cc:666: if
(!prefs->IsManagedPreference(prefs::kCloudPrintSubmitEnabled) ||
On 2011/10/27 09:01:23, pastarmovj wrote:
> I don't think you need the IsManagedPreference check here. If it is not
managed
> it will be either left to its default value which is true or the user could
> potentially write it in his Preferences file and set it to false in which case
> although undocumented it will be valid way to locally disable GCP.

Done.

[commit-bot: I haz the power, 2011-10-27 21:06:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8395007/16001

[commit-bot: I haz the power, 2011-10-27 21:55:44]

Try job failure for 8395007-16001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-10-28 16:20:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8395007/16001

[commit-bot: I haz the power, 2011-10-28 17:34:57]

Change committed as 107748

[Joao da Silva, 2011-10-28 18:56:56]

Drive by review, since this broke the pyauto tests. Please consider the comments
inline if you resubmit this. Thanks!

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
chrome/app/policy/policy_templates.json:103: #   For your editing convenience:
highest ID currently used: 108
Please update this number.

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
chrome/app/policy/policy_templates.json:1851: 'name': 'CloudPrintSubmitEnabled',
Please add an entry for this policy at
chrome/test/functional/policy_prefs_ui.py. Something like:

'CloudPrintSubmitEnabled': (False, [])

http://codereview.chromium.org/8395007/diff/16001/chrome/browser/policy/confi...
File chrome/browser/policy/config_dir_policy_provider_unittest.cc (right):

http://codereview.chromium.org/8395007/diff/16001/chrome/browser/policy/confi...
chrome/browser/policy/config_dir_policy_provider_unittest.cc:377:
key::kCloudPrintSubmitEnabled));
One ) missing.

Also notice that this is #if defined(OS_CHROMEOS), which probably is not what
you want. If the instantiation above is already at 50 cases, add a 3rd one.

[Albert Bodenhamer, 2011-10-28 22:06:06]

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
chrome/app/policy/policy_templates.json:103: #   For your editing convenience:
highest ID currently used: 108
On 2011/10/28 18:56:56, Joao da Silva wrote:
> Please update this number.

Done.

http://codereview.chromium.org/8395007/diff/16001/chrome/app/policy/policy_te...
chrome/app/policy/policy_templates.json:1851: 'name': 'CloudPrintSubmitEnabled',
On 2011/10/28 18:56:56, Joao da Silva wrote:
> Please add an entry for this policy at
> chrome/test/functional/policy_prefs_ui.py. Something like:
> 
> 'CloudPrintSubmitEnabled': (False, [])

Done.

http://codereview.chromium.org/8395007/diff/16001/chrome/browser/policy/confi...
File chrome/browser/policy/config_dir_policy_provider_unittest.cc (right):

http://codereview.chromium.org/8395007/diff/16001/chrome/browser/policy/confi...
chrome/browser/policy/config_dir_policy_provider_unittest.cc:377:
key::kCloudPrintSubmitEnabled));
On 2011/10/28 18:56:56, Joao da Silva wrote:
> One ) missing.
> 
> Also notice that this is #if defined(OS_CHROMEOS), which probably is not what
> you want. If the instantiation above is already at 50 cases, add a 3rd one.

Done.

[commit-bot: I haz the power, 2011-10-31 22:33:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/8395007/21001

[commit-bot: I haz the power, 2011-10-31 23:45:43]

Change committed as 108038