Files.app: Fix notifications that are popping up after an import has completed.

Files.app: Fix notifications that are popping up after a media import has completed.

The ImportTask appears to be firing a final progress event after the success event has been fired; this is causing the UI to pop up a zombie import-related progress notification that never goes away.  Fix by preventing the task from emitting further notifications once it's successfully completed.

BUG=420680
Committed: https://crrev.com/bd10c079c8a1a2c5725be6c3461cc848130a0f8e
Cr-Commit-Position: refs/heads/master@{#311498}

[Ben Kwa, 2015-01-12 19:38:59]

kenobi@chromium.org changed reviewers:
+ mtomasz@chromium.org, smckay@chromium.org

[Steve McKay, 2015-01-12 21:52:10]

Boolean allergies aside, LGTM provided Hirono-san knows of no good alternatives.

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/media_import_handler.js (right):

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/media_import_handler.js:186:
this.completed_ = false;
My boolean allergies are flaring up. But I don't see any immediate alternatives.
Let's see what Hirono says this afternoon.

[mtomasz, 2015-01-13 00:37:46]

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/media_import_handler.js (right):

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/media_import_handler.js:285:
completionCallback();
Won't moving the completionCallback invocation after this.notify(PROGRESS)
automagically resolve this issue?

[Ben Kwa, 2015-01-13 15:28:15]

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/media_import_handler.js (right):

https://codereview.chromium.org/839473006/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/media_import_handler.js:285:
completionCallback();
On 2015/01/13 00:37:46, mtomasz wrote:
> Won't moving the completionCallback invocation after this.notify(PROGRESS)
> automagically resolve this issue?

You're right, thanks!  This looks much better.

[mtomasz, 2015-01-14 00:21:51]

lgtm

[Ben Kwa, 2015-01-14 14:51:28]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2015-01-14 14:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839473006/20001

[commit-bot: I haz the power, 2015-01-14 14:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 14:54:32]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Ben Kwa, 2015-01-14 16:24:57]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2015-01-14 16:26:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/839473006/40001

[commit-bot: I haz the power, 2015-01-14 17:20:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-14 17:21:42]

Patchset 3 (id:??) landed as
https://crrev.com/bd10c079c8a1a2c5725be6c3461cc848130a0f8e
Cr-Commit-Position: refs/heads/master@{#311498}