Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7590)

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js

Issue 839453006: Do not show search bubble on printer advanced options text field change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
index 3d5438010fe07b04160bde1dfcfa4963049b6033..b8ae300e5e64bb44beccecf0996e5d8bf3e23b52 100644
--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js
@@ -151,10 +151,11 @@ cr.define('print_preview', function() {
if (this.query_) {
var optionMatches = (this.selectedValue_ || '').match(this.query_);
// Even if there's no match anymore, keep the item visible to do not
- // surprise user.
- if (optionMatches)
- this.showSearchBubble_(optionMatches[0]);
- else
+ // surprise user. Even if there's a match, do not show the bubble, user
+ // is already aware that this option is visible and matches the search.
+ // Showing the bubble will only create a distraction by moving UI
+ // elements around.
+ if (!optionMatches)
this.hideSearchBubble_();
}
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698