Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 839453002: Update the device permissions prompt when the device list changes. (Closed)

Created:
5 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the device permissions prompt when the device list changes. This patch sets up DevicePermissionsPrompt::Prompt as a UsbService::Observer so that the UI is updated whenever a device is connected or disconnected. BUG=411715 Committed: https://crrev.com/6871112deb52f0469df3b9b2d8f11f2a78ee89de Cr-Commit-Position: refs/heads/master@{#310157}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -77 lines) Patch
M extensions/browser/api/device_permissions_prompt.h View 4 chunks +21 lines, -9 lines 0 comments Download
M extensions/browser/api/device_permissions_prompt.cc View 5 chunks +98 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Yoyo, please take a look at this patch.
5 years, 11 months ago (2015-01-05 19:31:26 UTC) #2
Yoyo Zhou
LGTM
5 years, 11 months ago (2015-01-06 00:01:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839453002/20001
5 years, 11 months ago (2015-01-06 21:21:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 22:11:25 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 22:12:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6871112deb52f0469df3b9b2d8f11f2a78ee89de
Cr-Commit-Position: refs/heads/master@{#310157}

Powered by Google App Engine
This is Rietveld 408576698